vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement
JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r269253834
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
##########
@@ -107,6 +107,23 @@ public QueryContext(final UserSession session, final
DrillbitContext drillbitCon
this.table = drillbitContext.getOperatorTable();
}
+ // Checking for limit on ResultSet rowcount and if user attempting to
override the system value
+ final int sessionMaxRowCount =
queryOptions.getOption(ExecConstants.QUERY_MAX_ROWS).num_val.intValue();
Review comment:
I'm not sure that it was exactly the same case, but in this case `final` is
redundant. The scope of variable usage is small, and there is no risk of
accidental changing its value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
