vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269033910
########## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ########## @@ -462,4 +618,25 @@ public void testParamSettingWhenUnsupportedTypeSaysUnsupported() throws SQLExcep } } + + // Sets the SystemMaxRows option + private void setSystemMaxRows(int sysValueToSet) throws SQLException { + // Acquire lock if Non-Zero Value (i.e. a test is in progress) + if (sysValueToSet != 0) { + maxRowsSysOptionLock.acquireUninterruptibly(); + } + // Setting the value + try (Statement stmt = connection.createStatement()) { + stmt.executeQuery(ALTER_SYS_OPTIONS_MAX_ROWS_LIMIT_X + sysValueToSet); + ResultSet rs = stmt.getResultSet(); Review comment: Is it required to obtain a result set and iterate thru it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services