vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269709745
########## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java ########## @@ -259,4 +261,13 @@ public void setObject(int parameterIndex, Object x, SQLType targetSqlType) throw checkOpen(); super.setObject(parameterIndex, x, targetSqlType); } + + @Override + public void setLargeMaxRows(long maxRowCount) throws SQLException { + super.setLargeMaxRows(maxRowCount); + try (Statement statement = this.connection.createStatement()) { + statement.execute("ALTER SESSION SET `" + ExecConstants.QUERY_MAX_ROWS + "`=" + maxRowCount); + statement.close(); Review comment: Please remove this line, `statement` will be closed automatically since it is used in `try with resources`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services