vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement
JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r271853531
##########
File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java
##########
@@ -69,6 +78,17 @@ public static void tearDownStatement() throws SQLException {
connection.close();
}
+ @Before
Review comment:
This will slow down all the tests in this class besides your tests.
Also, since connection string is `jdbc:drill:zk=local`, so separate embedded
drill instance will be used for every test class and there is no need to lock
other test classes.
Could you please move all your tests into a separate class and add lock
there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
