kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC
Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r269759078
##########
File path:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
##########
@@ -537,7 +547,14 @@ public void
testclosedPreparedStmtOfOpenConnMethodsThrowRight() {
new ClosedPreparedStatementChecker(PreparedStatement.class,
closedPreparedStmtOfOpenConn);
- checker.testAllMethods();
+ //List of methods now supported
+ Set<String> methodsToSkip = new LinkedHashSet<String>() {{
Review comment:
Ok. These tests were failing because it we had implemented the
`setMaxRows()` and `getMaxRows()` methods. These tests, it seems, expected them
to throw exceptions.
With the `super.setLargeMaxRows()`, this should not be necessary anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
