kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r270291552
########## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ########## @@ -462,4 +618,25 @@ public void testParamSettingWhenUnsupportedTypeSaysUnsupported() throws SQLExcep } } + + // Sets the SystemMaxRows option + private void setSystemMaxRows(int sysValueToSet) throws SQLException { Review comment: Strangely enough, these tests have never failed... so, I'm presuming the tests run fast enough with a low level of parallelization. I can set the `assert` to check for a non-zero value for the timeout test. Alternatively, I could disable the tests: `testSetMaxRowsHigherThanSystemLimit()` and `testSetMaxRowsLowerThanSystemLimit()` Which one should I do? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services