arina-ielchiieva commented on a change in pull request #1794: DRILL-7196:
Queries are still runnable on disabled plugins
URL: https://github.com/apache/drill/pull/1794#discussion_r286353666
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/store/TestDisabledPlugin.java
##########
@@ -70,11 +68,16 @@ public void testDisabledPluginQuery() throws Exception {
public void testUseStatement() throws Exception {
try {
run("use cp");
- fail("Query should have failed!");
+ Assert.fail("Query should have failed!");
} catch (UserRemoteException e) {
- assertEquals(UserBitShared.DrillPBError.ErrorType.VALIDATION,
e.getErrorType());
- assertTrue("Incorrect error message",
+ Assert.assertEquals(UserBitShared.DrillPBError.ErrorType.VALIDATION,
e.getErrorType());
+ Assert.assertTrue("Incorrect error message",
e.getMessage().contains("VALIDATION ERROR: Schema"));
}
}
+
+ @Test
+ public void testDisabledPluginGet() throws Exception {
+ Assert.assertNull(pluginRegistry.getPlugin(CP_PLUGIN_NAME));
Review comment:
static import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
