arina-ielchiieva commented on a change in pull request #1794: DRILL-7196: 
Queries are still runnable on disabled plugins
URL: https://github.com/apache/drill/pull/1794#discussion_r286351875
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
 ##########
 @@ -121,10 +121,9 @@ public Viewable getPlugins() {
   @Produces(MediaType.APPLICATION_JSON)
   public PluginConfigWrapper getPluginConfig(@PathParam("name") String name) {
     try {
-      // TODO: DRILL-6412: No need to get StoragePlugin. It is enough to have 
plugin name and config here
-      StoragePlugin plugin = storage.getPlugin(name);
-      if (plugin != null) {
-        return new PluginConfigWrapper(name, plugin.getConfig());
+      PersistentStore<StoragePluginConfig>  configStorage = storage.getStore();
 
 Review comment:
   ```suggestion
         PersistentStore<StoragePluginConfig> configStorage = 
storage.getStore();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to