arina-ielchiieva commented on a change in pull request #1798: DRILL-7279:
Enable provided schema for text files without headers
URL: https://github.com/apache/drill/pull/1798#discussion_r289931276
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/TupleMetadata.java
##########
@@ -46,6 +46,10 @@
public interface TupleMetadata extends Propertied, Iterable<ColumnMetadata> {
public static final String IS_STRICT_SCHEMA_PROP = DRILL_PROP_PREFIX +
"strict";
+ public static final String HAS_HEADERS_PROP = DRILL_PROP_PREFIX + "headers";
+ public static final String SKIP_FIRST_LINE_PROP = DRILL_PROP_PREFIX +
"skipFirstLine";
+ public static final String DELIMITER_PROP = DRILL_PROP_PREFIX + "delimiter";
+ public static final String COMMENT_CHAR_PROP = DRILL_PROP_PREFIX +
"commentChar";
Review comment:
Why we only have four properties since we adding such support it would be
fair to add all text properties, there are not that many of them. Since I
believe fo the the user it would be confusing why only some of them are
supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
