arina-ielchiieva commented on a change in pull request #1798: DRILL-7279: Enable provided schema for text files without headers URL: https://github.com/apache/drill/pull/1798#discussion_r289927887
########## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/TupleMetadata.java ########## @@ -46,6 +46,10 @@ public interface TupleMetadata extends Propertied, Iterable<ColumnMetadata> { public static final String IS_STRICT_SCHEMA_PROP = DRILL_PROP_PREFIX + "strict"; + public static final String HAS_HEADERS_PROP = DRILL_PROP_PREFIX + "headers"; Review comment: I am not sure this should be placed here, these properties are mostly related to text readers unlike `IS_STRICT_SCHEMA_PROP` or `TupleMetadata` class itself. Maybe its better to move these properties to separate class which will clearly indicate that they are applicable for the text readers only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services