arina-ielchiieva commented on a change in pull request #1797: DRILL-7278:
Refactor result set loader projection mechanism
URL: https://github.com/apache/drill/pull/1797#discussion_r289944701
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/project/ProjectionType.java
##########
@@ -15,19 +15,70 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.drill.exec.record.metadata;
+package org.apache.drill.exec.physical.rowSet.project;
import org.apache.drill.common.types.TypeProtos.DataMode;
import org.apache.drill.common.types.TypeProtos.MajorType;
import org.apache.drill.common.types.TypeProtos.MinorType;
+/**
+ * Specifies the type of projection obtained by parsing the
+ * projection list. The type is returned from a query of the
+ * form "how is this column projected, if at all?"
+ * <p>
+ * The projection type allows the scan framework to catch
+ * inconsistencies, such as projecting an array as a map,
+ * and so on.
+ */
+
public enum ProjectionType {
+
+ /**
+ * The column is not projected in the query.
+ */
+
UNPROJECTED,
+
+ /**
+ * Projection is a wildcard.
+ */
WILDCARD, // *
- UNSPECIFIED, // x
+
+ /**
+ * Projection is by simple name. "General" means that
+ * we have no hints about the type of the column from
+ * the projection.
+ */
+
+ GENERAL, // x
Review comment:
Not sure if `GENERAL` is better than `UNSPECIFIED` but let it be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
