arina-ielchiieva commented on a change in pull request #1797: DRILL-7278:
Refactor result set loader projection mechanism
URL: https://github.com/apache/drill/pull/1797#discussion_r289945691
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/project/ProjectionType.java
##########
@@ -53,13 +109,26 @@ public static ProjectionType typeFor(MajorType majorType)
{
if (majorType.getMode() == DataMode.REPEATED) {
return ARRAY;
}
+ if (majorType.getMinorType() == MinorType.LIST) {
+ return ARRAY;
+ }
return SCALAR;
}
- public boolean isCompatible(ProjectionType other) {
- switch (other) {
+ /**
+ * Reports if this type (representing an item in a projection list)
+ * is compatible with the projection type representing an actual
+ * column produced by an operator. The check is not symmetric.
Review comment:
`The check is not symmetric.` could you please explain this part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
