arina-ielchiieva commented on a change in pull request #1807: DRILL-7293: 
Convert the regex ("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r293690297
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/store/log/TestLogReader.java
 ##########
 @@ -389,4 +416,56 @@ public void testRawUMNoSchema() throws RpcException {
 
     RowSetUtilities.verify(expected, results);
   }
+
+  @Test
+  public void testProvidedSchema() throws Exception {
 
 Review comment:
   `select * from table(t(schema=>'inline=(col1 varchar)'))` should work 
disregarding format properties. But log format has schema property so I am 
wondering if there will be a clash or schema parameter will be correctly 
resolved, since log format has it as list and schema provisioning in string.
   Since now log format supports schema provisioning, the above query should 
apply schema for log files, could you please check this query?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to