arina-ielchiieva commented on a change in pull request #1807: DRILL-7293:
Convert the regex ("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r293692739
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java
##########
@@ -47,23 +47,30 @@
import org.slf4j.LoggerFactory;
public class LogFormatPlugin extends EasyFormatPlugin<LogFormatConfig> {
- public static final String PLUGIN_NAME = "logRegex";
private static final Logger logger =
LoggerFactory.getLogger(LogFormatPlugin.class);
+ public static final String PLUGIN_NAME = "logRegex";
+ public static final String PROP_PREFIX = TupleMetadata.DRILL_PROP_PREFIX +
"regex.";
Review comment:
Since properties are `log` specific should we add `log` in the properties
naming as well as we did for `text` properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
