paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert
PCAP Format Plugin to EVF
URL: https://github.com/apache/drill/pull/1862#discussion_r331767290
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapRecordReader.java
##########
@@ -45,8 +45,16 @@ public void testStarQuery() throws Exception {
@Test
public void testCorruptPCAPQuery() throws Exception {
runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap`", 7000);
- runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=false", 6408);
- runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=true", 592);
+ }
+
+ @Test
+ public void testTrueCorruptPCAPQuery() throws Exception {
+ runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=true", 16);
+ }
+
+ @Test
+ public void testNotCorruptPCAPQuery() throws Exception {
+ runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=false", 6984);
Review comment:
Looks like the original test were pretty light. It leaves to the user to
test per-column setup and type conversions.
Would recommend adding tests that:
1) Verify the schema: names, types
2) Verifies the data (using the usual mechanism to read a few rows and
validate the results.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
