paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert
PCAP Format Plugin to EVF
URL: https://github.com/apache/drill/pull/1862#discussion_r331765097
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatConfig.java
##########
@@ -17,12 +17,27 @@
*/
package org.apache.drill.exec.store.pcap;
+import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonTypeName;
import org.apache.drill.common.logical.FormatPluginConfig;
+import org.apache.drill.shaded.guava.com.google.common.collect.ImmutableList;
+
+import java.util.List;
@JsonTypeName("pcap")
public class PcapFormatConfig implements FormatPluginConfig {
+ private static final List<String> DEFAULT_EXTS = ImmutableList.of("pcap");
+ public List<String> extensions;
+
+ @JsonInclude(JsonInclude.Include.NON_DEFAULT)
+ public List<String> getExtensions() {
+ if (extensions == null) {
+ return DEFAULT_EXTS;
+ }
+ return extensions;
Review comment:
Nit: `return extensions == null ? DEFAULT_EXTS : extensions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
