paul-rogers commented on a change in pull request #1899: DRILL-7445: Create 
batch copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r348095757
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/types/Types.java
 ##########
 @@ -806,16 +806,20 @@ public static boolean isSortable(MinorType type) {
     return typeBuilder;
   }
 
+  public static boolean isSameType(MajorType type1, MajorType type2) {
 
 Review comment:
   This was pulled out to use elsewhere: it checks if the "core" type is the 
same, ignoring the child details.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to