paul-rogers commented on a change in pull request #1899: DRILL-7445: Create
batch copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r348101045
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/VectorContainerAccessor.java
##########
@@ -22,41 +22,83 @@
import org.apache.drill.common.expression.SchemaPath;
import org.apache.drill.exec.record.BatchSchema;
+import org.apache.drill.exec.record.RecordBatch;
import org.apache.drill.exec.record.TypedFieldId;
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.record.WritableBatch;
import org.apache.drill.exec.record.selection.SelectionVector2;
import org.apache.drill.exec.record.selection.SelectionVector4;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
public class VectorContainerAccessor implements BatchAccessor {
- public static class ContainerAndSv2Accessor extends VectorContainerAccessor {
+ public static class ExtendedContainerAccessor extends
VectorContainerAccessor {
Review comment:
Extracted and renamed class. The original code had two subclasses. I used
this as a batch holder for the row set copier. However, I found that, in
practice, an operator has no control over the form of its input container uses.
So, this version of the class allows accepting any form: no SV, an SV2 or SV4.
Yes, it would be better to have a fixed class, but we'll need a bit more
work before that is possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
