paul-rogers commented on a change in pull request #1929: DRILL-6832: Remove the
old "unmanaged" external sort
URL: https://github.com/apache/drill/pull/1929#discussion_r361595214
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
##########
@@ -71,38 +61,22 @@ public void mergeSortWithSv2Legacy() throws Exception {
* @throws Exception
*/
- private void mergeSortWithSv2(boolean testLegacy) throws Exception {
- ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
- .configProperty(ExecConstants.EXTERNAL_SORT_DISABLE_MANAGED, false);
+ @Test
Review comment:
Actually, what is happening here is removing the previous code that ran the
tests twice: once for the "unmanaged" sort, the other for "managed." The
original "driver" function is gone, the "implementation" is now the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
