paul-rogers commented on a change in pull request #1929: DRILL-6832: Remove the old "unmanaged" external sort URL: https://github.com/apache/drill/pull/1929#discussion_r361596368
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortEmitOutcome.java ########## @@ -15,9 +15,15 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.drill.exec.physical.impl.xsort.managed; +package org.apache.drill.exec.physical.impl.xsort; + +import static junit.framework.TestCase.assertTrue; Review comment: We need to agree on an import order. (See DRILL-7352.) I have tried working on Drill with auto import management turned off in Eclipse. It is VERY painful. Our Developer documentation provides an Eclipse styles template that (should) include import ordering. Somewhere along the line, the Intellij folks started using a different ordering. We need to decide on an import ordering. Does not matter what it is as long as both IDEs can enforce it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
