paul-rogers commented on a change in pull request #1929: DRILL-6832: Remove the
old "unmanaged" external sort
URL: https://github.com/apache/drill/pull/1929#discussion_r361574585
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/BatchGroup.java
##########
@@ -221,4 +363,19 @@ public SelectionVector4 getSelectionVector4() {
throw new UnsupportedOperationException();
}
+ public static void closeAll(Collection<? extends BatchGroup> groups) {
Review comment:
This is called from several places, so left the method in place. Did replace
the code with the `AutoCloseables` call. Did the exception translation in this
method since there seemed little value in cluttering `AutoCloseables` with the
exception translation logic, or a lamda to do the work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
