ihuzenko commented on issue #1944: DRILL-7503: Refactor the project operator
URL: https://github.com/apache/drill/pull/1944#issuecomment-570618977
 
 
   @paul-rogers thanks for the quick update. I agree that using the already 
generated and compiled code whenever possible would be very good in the long 
run. Also, I agree with the step-by-step refactoring approach. With respect to 
this PR, I propose to extract the ```VectorState``` into a separate class 
together with all the ```ProjectRecordBatch```'s fields that can be 
encapsulated. I believe that the extraction of ```VectorState``` won't allow 
using mixed access to fields in the future and opens more ways for later 
improvements. In order to better express my thought, I created the sample 
[commit](https://github.com/ihuzenko/drill/commit/80fb0065cf4d11b836383b031dffc07b92a5ad91).
 Sorry for the late reply.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to