ihuzenko commented on issue #1944: DRILL-7503: Refactor the project operator
URL: https://github.com/apache/drill/pull/1944#issuecomment-571034273
 
 
   Hello @paul-rogers , if you don't want to extract the ```VectorState``` 
class then at least please put related fields into it, so it'll be visible 
which state is managed by the class. Although extraction is better way for me, 
since it won't allow anybody to easily mix access to related fields 
(```transfers, allocationVectors, complexWriters, complexFieldReferences 
etc...```). PS. Here there is no quick solution without serious rewriting to 
make everything look good:)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to