cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata Queries Fail with Large Files URL: https://github.com/apache/drill/pull/1978#discussion_r380683693
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -92,6 +93,20 @@ private static final String LONG_COLUMN_NAME = "long_data"; + private static final String DATA_SIZE_COLUMN_NAME = "data_size"; + + private static final String ELEMENT_COUNT_NAME = "element_count"; + + private static final String IS_TIMESTAMP_NAME = "is_timestamp"; Review comment: @paul-rogers I debated adding these. At the moment, Drill/HDF5 does support reading `TIMESTAMP` columns as `TIMESTAMPS`. I wasn't aware of intervals as an HDF5 data type so the current implementation doesn't support that. I can create a PR to support Intervals and work on it if there is usage/demand for it. Do you think I should remove these columns from the metadata view? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services