cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata 
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r380916913
 
 

 ##########
 File path: 
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
 ##########
 @@ -98,9 +98,9 @@ public void testStarQuery() throws Exception {
 
     testBuilder()
       .sqlQuery("SELECT * FROM dfs.`hdf5/dset.h5`")
-      .unOrdered()
-      .baselineColumns("path", "data_type", "file_name", "int_data")
-      .baselineValues("/dset", "DATASET", "dset.h5", finalList)
+      .ordered()
 
 Review comment:
   In retrospect, the best way would probably be to do some sort of hybrid 
plugin that has access to the Calcite schema. That way you could add the HDF5 
data path after the file.  If there isn't a data path.. you get metadata only.  
However, I suspect that would be very difficult with the current architecture 
and would involve a lot of cut/paste and or extending from the file system 
plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to