paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r384890642
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -65,6 +65,7 @@ public static void setup() throws Exception {
ExcelFormatConfig formatConfig = new ExcelFormatConfig();
cluster.defineFormat("cp", "excel", formatConfig);
+ cluster.defineFormat("dfs", "excel", formatConfig);
Review comment:
The tests failed without it. Don't know why. I suspect this is a result of
being more strict about not mucking with configs after they are stored in the
plugin registry. That is, the prior behavior was wrong, but benign. This change
is "more right."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
