paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r384893271
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/StoragePlugins.java
##########
@@ -48,7 +56,12 @@ public StoragePlugins(@JsonProperty("storage") Map<String,
StoragePluginConfig>
this.storage = caseInsensitiveStorage;
}
- public static void main(String[] args) throws Exception{
+ public StoragePlugins() {
+ this(new HashMap<>());
+ }
+
+ // TODO: Move to a test
Review comment:
Tried to move to a test. Code does not work. Functionality itself tested
indirectly in new registry unit tests, so just deleted the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
