weijietong commented on a change in pull request #2000: DRILL-7607: Support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386796660
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.java
##########
@@ -32,12 +33,24 @@
private final int softlimit;
private final int startlimit;
- public UnlimitedRawBatchBuffer(FragmentContext context, int fragmentCount) {
- super(context, fragmentCount);
+ private int runtimeSoftLimit = -1;
+ private int runtimeAckCredit = 1;
+ private int sampleTimes = 0;
+ private long totalBatchSize = 0l;
+ private final int fragmentCount;
+ private final int maxSampleTimes;
+ private final long thresholdNetworkMem;
+
+ public UnlimitedRawBatchBuffer(FragmentContext context, int fragmentCount,
boolean enableDynamicFC) {
+ super(context, fragmentCount, enableDynamicFC);
this.softlimit = bufferSizePerSocket * fragmentCount;
this.startlimit = Math.max(softlimit/2, 1);
logger.trace("softLimit: {}, startLimit: {}", softlimit, startlimit);
this.bufferQueue = new UnlimitedBufferQueue();
+ this.fragmentCount = fragmentCount;
+ this.sampleTimes = fragmentCount;
+ this.maxSampleTimes = fragmentCount;
+ this.thresholdNetworkMem =
context.getConfig().getLong(ExecConstants.UNLIMITED__BUFFER_MAX_MEMORY_SIZE);
Review comment:
Since we already have a configure item to control this feature. Why we still
need to set the limited buffer size to 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
