Hi all, Thanks, Laurent for creating this release candidate!
I have started verifying the release, but for now my vote is -1 (binding) because of the following issue: DRILL-7945 <https://issues.apache.org/jira/browse/DRILL-7945> It is definitely a regression and it might break some important Drill functionality so I'm considering it as a blocker for the release. Kind regards, Volodymyr Vysotskyi On 2021/06/03 17:14:37, Laurent Goujon <l...@dremio.com> wrote: > Hey guys,> > > Can we please stop changing the goal post again and again? The fact that> > some of those pull requests are ready to merge should not be the sole> > consideration when to do a next release candidate.> > > I've been asking several times on this mailing list about what we want to> > include or not, and we got an agreement several times about it, and several> > times we are now having this conversation.> > IMHO, I would not include DRILL-7941, DRILL-7942 and DRILL-7943: those are> > new enhancements impacting Drill tests (not even the main product) and I do> > not understand the rush in making them part of the release. Specifically> > for the JUnit 5 update, I think the change is misleading because it looks> > like it's only the introduction of JUnit5 in one test class and everything> > else still uses JUnit 4, so I would hardly call it an upgrade...> > > As for DRILL-7937 and DRILL-7940, the issues were open in the last 3 days> > ago, but they do not seem to be regressions since 1.18.0, just gaps in what> > Drill provides. Personally since we are this deep in the release, I would> > also skip these one too. But if people have more contexts on those, maybe> > we can agree they should be merged?> > > Laurent> > > > On Thu, Jun 3, 2021 at 6:10 AM Charles Givre <cg...@gmail.com> wrote:> > > > There are like 5 minor PRs that are approved and awaiting merge. I'd vote> > > that we include them. Specifically:> > >> > > DRILL-7943: Update Hamcrest> > > DRILL-7942: Update Mockito> > > DRILL-7941: Update junit to 5.7.2> > > DRILL-7937: Parquet decimal error> > > DRILL-7940: Fix Kafka Key> > >> > > These are all approved and can be merged.> > >> > > -- C> > >> > > > On Jun 3, 2021, at 9:01 AM, luoc <lu...@apache.org> wrote:> > > >> > > >> > > > DRILL-7940, too> > > >> > > >> 在 2021年6月3日，19:57，Charles Givre <cg...@gmail.com> 写道：> > > >>> > > >> -1 (Binding)> > > >>> > > >> I'd agree with Nick. Drill-7937 should be included in this release.> > > >> -- C> > > >>> > > >>> On Jun 2, 2021, at 9:25 AM, Nick Stenroos-Dam <ni...@project.bi> > > >>> wrote:> > > >>>> > > >>> Vote -1> > > >>>> > > >>> Can we please include DRILL-7937> > > >> > >> > >> >
