dzamo commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710087396
##########
File path: Dockerfile
##########
@@ -16,31 +16,53 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project
sources into the build image, builds
-# Drill and copies built binaries into the target image based on
openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_NAME
+# env var which you should set when invoking docker build.
+# Example BASE_NAME values: openjdk:8-jre, openjdk:11-jre, openjdk:latest
# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+FROM maven:3.8.2-openjdk-11 as build
Review comment:
Oh I better check this, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
