vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710157786
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project
sources into the build image, builds
-# Drill and copies built binaries into the target image based on
openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
Review comment:
Please use JDK 8 as a default one.
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project
sources into the build image, builds
-# Drill and copies built binaries into the target image based on
openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
-# Copy project sources into the container
-COPY . /src
+# Uses intermediate image for building Drill to reduce target image size
+# Build using OpenJDK 8 to maintain compatibility with all OpenJDK >= 8
+FROM maven:3.8.2-openjdk-8 as build
Review comment:
It can be made configurable too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
