vvysotskyi commented on a change in pull request #2388:
URL: https://github.com/apache/drill/pull/2388#discussion_r781256339
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java
##########
@@ -154,17 +156,23 @@ public SchemaPlus createFullRootSchema(SchemaConfig
schemaConfig) {
.build(logger);
}
}
+ */
@Override
public void close() throws Exception {
+ //TODO jnturton: clean up
+ /*
List<AutoCloseable> toClose = Lists.newArrayList();
for(SchemaPlus tree : schemaTreesToClose) {
addSchemasToCloseList(tree, toClose);
}
AutoCloseables.close(toClose);
+ */
}
+ //TODO jnturton: clean up
+ /*
private static void addSchemasToCloseList(final SchemaPlus tree, final
List<AutoCloseable> toClose) {
for(String subSchemaName : tree.getSubSchemaNames()) {
addSchemasToCloseList(tree.getSubSchema(subSchemaName), toClose);
Review comment:
Yes, initially I had doubts about this change, but for now, I propose to
delete this method. For the case when someone would need to add some special
logic under it, this change might be reconsidered. But we should be sure that
changes in this PR are covered by tests, so breaking this optimization would be
easily detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
