jnturton commented on a change in pull request #2388:
URL: https://github.com/apache/drill/pull/2388#discussion_r784968419



##########
File path: 
exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java
##########
@@ -150,6 +150,11 @@ public String getTypeName() {
           DataContext.ROOT,
           BuiltInMethod.DATA_CONTEXT_GET_ROOT_SCHEMA.method);
     }
+
+    @Override
+    public boolean showInInformationSchema() {
+      return false;
+    }
   }

Review comment:
       @cgivre here's the description on this method in AbstractSchema.  I 
believe it was added when the information_schema db was originally developed.
   ```
     /**
      * Reports whether to show items from this schema in INFORMATION_SCHEMA
      * tables.
      * (Controls ... TODO:  Doc.:  Mention what this typically controls or
      * affects.)
      * <p>
      *   This base implementation returns {@code true}.
      * </p>
      */
     public boolean showInInformationSchema() {
       return true;
     }
   ```
   
   The override in this PR says "don't show the root schema in query results 
from information_schema". 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to