vdiravka commented on a change in pull request #2432:
URL: https://github.com/apache/drill/pull/2432#discussion_r795446355
##########
File path:
contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcWriterWithH2.java
##########
@@ -142,14 +142,14 @@ public void testBasicCTASWithDataTypes() throws Exception
{
DirectRowSet results = queryBuilder().sql(testQuery).rowSet();
TupleMetadata expectedSchema = new SchemaBuilder()
- .addNullable("int_field", MinorType.INT, 10)
- .addNullable("bigint_field", MinorType.BIGINT, 19)
- .addNullable("float4_field", MinorType.VARDECIMAL, 38, 37)
- .addNullable("float8_field", MinorType.VARDECIMAL, 38, 37)
+ .addNullable("int_field", MinorType.INT, 32)
+ .addNullable("bigint_field", MinorType.BIGINT, 38)
+ .addNullable("float4_field", MinorType.FLOAT4, 38)
+ .addNullable("float8_field", MinorType.FLOAT8, 38)
Review comment:
Does it mean we started supporting float with new h2 version?
##########
File path: pom.xml
##########
@@ -104,7 +104,7 @@
<license.skip>true</license.skip>
<docker.repository>apache/drill</docker.repository>
<antlr.version>4.8-1</antlr.version>
- <maven.version>3.6.3</maven.version>
+ <maven.version>3.8.4</maven.version>
Review comment:
You can update `Envirnment.md` with links to recommended and minimum
Maven versions :
```
...
To build, you need to have the following software installed on your system
to successfully complete a build.
* Java 8
* Maven 3.6.3 or greater
```
##########
File path: pom.xml
##########
@@ -92,20 +92,21 @@
<javassist.version>3.28.0-GA</javassist.version>
<msgpack.version>0.6.6</msgpack.version>
<reflections.version>0.9.10</reflections.version>
- <avro.version>1.9.1</avro.version>
+ <avro.version>1.11.0</avro.version>
<metrics.version>4.0.2</metrics.version>
- <jetty.version>9.4.41.v20210516</jetty.version>
+ <jetty.version>9.4.44.v20210927</jetty.version>
<jersey.version>2.34</jersey.version>
<javax.validation.api>2.0.1.Final</javax.validation.api>
<asm.version>9.2</asm.version>
<excludedGroups />
- <memoryMb>1800</memoryMb>
- <directMemoryMb>3000</directMemoryMb>
+ <memoryMb>2000</memoryMb>
+ <directMemoryMb>2700</directMemoryMb>
<rat.skip>true</rat.skip>
<license.skip>true</license.skip>
<docker.repository>apache/drill</docker.repository>
<antlr.version>4.8-1</antlr.version>
- <maven.version>3.6.3</maven.version>
+ <maven.version>3.8.4</maven.version>
+ <maven.version.min>3.6.3</maven.version.min>
Review comment:
What about:
```suggestion
<maven.min.version>3.6.3</maven.min.version>
```
##########
File path: distribution/pom.xml
##########
@@ -199,28 +199,30 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64-fedora</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <!-- bump warning: windows-x86_64 jars apparently stopped being published
+ after 2.0.36, see
https://repo1.maven.org/maven2/io/netty/netty-tcnative/ -->
+ <version>2.0.36.Final</version>
Review comment:
you are right, `2.0.48.Final` for windows is missing. But looks like it
is present for
[2.0.46.Final](https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.46.Final/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
