vdiravka commented on a change in pull request #2432:
URL: https://github.com/apache/drill/pull/2432#discussion_r795453094
##########
File path: distribution/pom.xml
##########
@@ -199,28 +199,30 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64-fedora</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <!-- bump warning: windows-x86_64 jars apparently stopped being published
+ after 2.0.36, see
https://repo1.maven.org/maven2/io/netty/netty-tcnative/ -->
+ <version>2.0.36.Final</version>
Review comment:
you are right, `2.0.48.Final` for windows is missing. But looks like it
is present for
[2.0.46.Final](https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.46.Final/)
##########
File path: distribution/pom.xml
##########
@@ -199,28 +199,30 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64-fedora</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <!-- bump warning: windows-x86_64 jars apparently stopped being published
+ after 2.0.36, see
https://repo1.maven.org/maven2/io/netty/netty-tcnative/ -->
+ <version>2.0.36.Final</version>
Review comment:
I see all versions pom file has different sections related to windows,
but you are right specific `windows-x86_64` jar is absent (only general,
without OS name).
Let's leave `2.0.36.Final` for now, since it is not very important -
`<scope>test</scope>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
