jnturton commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148553607
I have a question relating to the earlier PR #2566 for this conversion. `JsonLoaderImpl` acquired a new `fromString` method, but it only needed to do that to accommodate the String returned by `SimpleHttp::makeSimpleGetRequest`. It seems to me that we can avoid copying scan data into a String on the heap here by making `SimpleHttp::makeSimpleGetRequest` return a stream instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
