vdiravka commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891201812
########## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ########## @@ -75,9 +75,6 @@ public void eval() { // as an approximation of null-if-null handling. if (args == null) { // Return empty map - org.apache.drill.exec.vector.complex.writer.BaseWriter.MapWriter mapWriter = writer.rootAsMap(); - mapWriter.start(); Review Comment: We don't need it. but isince t is `@Output` it is required for the UDF signature and can't be removed. It can be checked one more time again once `complexWriters` are removed from all UDFs. I've added todo to remove it. I can back to it, once migrating some other UDF to the new JSON parser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org