cgivre commented on code in PR #2571:
URL: https://github.com/apache/drill/pull/2571#discussion_r893386350
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -153,10 +149,15 @@ public void setup() {
drillbitContext,
pluginName
);
+
endpointConfig =
org.apache.drill.exec.store.http.util.SimpleHttp.getEndpointConfig(
endpointName,
plugin.getConfig()
);
+
+ // Add JSON configuration from Storage plugin, if present.
+ jsonLoaderBuilder =
org.apache.drill.exec.store.http.udfs.HttpUdfUtils.setupJsonBuilder(endpointConfig,
loader, options);
Review Comment:
Yes. Plus also if the logic is not in the UDF it is easier to add
breakpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
