[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

[GitBox]

vdiravka commented on code in PR #2571:
URL: https://github.com/apache/drill/pull/2571#discussion_r894210913


##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -153,10 +149,15 @@ public void setup() {
         drillbitContext,
         pluginName
       );
+
       endpointConfig = 
org.apache.drill.exec.store.http.util.SimpleHttp.getEndpointConfig(
         endpointName,
         plugin.getConfig()
       );
+
+      // Add JSON configuration from Storage plugin, if present.
+      jsonLoaderBuilder = 
org.apache.drill.exec.store.http.udfs.HttpUdfUtils.setupJsonBuilder(endpointConfig,
 loader, options);

Review Comment:
   It can be easly debug after uncommenting this 
[saveCode](https://github.com/apache/drill/blob/570ce63088ab4e2b479b53a9b41696adbb0c9278/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java#L303)
 line of code in `ProjectRecordBatch`.
   You can find more info in 
[GeneratedCode.md](https://github.com/apache/drill/blob/dc8d0107cb6a4a31e1beaa9c98d6e51cf7486a67/docs/dev/GeneratedCode.md#instructions-for-intellij)
 doc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org