vvysotskyi commented on code in PR #2583:
URL: https://github.com/apache/drill/pull/2583#discussion_r915109655
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockTableDef.java:
##########
@@ -84,6 +85,19 @@ public String toString() {
}
}
+ /**
+ * An unfortunate hack that adds required DrillTableSelection behaviour to
+ * the entries list while keeping its serialised form a JSON array to remain
+ * compatible with existing, serialised logical plan JSON files as may be
+ * found in the Drill unit test code, for example.
+ */
+ public static class MockTableSelection extends ArrayList<MockScanEntry>
implements DrillTableSelection {
Review Comment:
Yes, it would be better to modify plans, but this approach is also ok.
Another one is to add a custom deserialisation for the wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
