jnturton commented on code in PR #2583: URL: https://github.com/apache/drill/pull/2583#discussion_r915822192
########## exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockTableDef.java: ########## @@ -84,6 +85,19 @@ public String toString() { } } + /** + * An unfortunate hack that adds required DrillTableSelection behaviour to + * the entries list while keeping its serialised form a JSON array to remain + * compatible with existing, serialised logical plan JSON files as may be + * found in the Drill unit test code, for example. + */ + public static class MockTableSelection extends ArrayList<MockScanEntry> implements DrillTableSelection { Review Comment: @vvysotskyi I've changed this to a wrapper and modified the two instances of existing test plan JSON. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org