vvysotskyi commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r932494153
########## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileBatchReader.java: ########## @@ -154,6 +153,19 @@ public boolean next() { @Override public void close() { - AutoCloseables.closeSilently(reader); + try { + // Hadoop 2 compat: {@link org.apache.hadoop.mapred.RecordReader} does not + // support AutoCloseable and must be closed manually. + if (reader != null) { + reader.close(); + reader = null; + } + } catch (IOException e) { + throw UserException Review Comment: `AutoCloseables.closeSilently` doesn't throw any errors. ########## exec/jdbc-all/pom.xml: ########## @@ -1230,7 +1230,7 @@ <profile> <id>hadoop-2</id> <properties> - <jdbc-all-jar.maxsize>50400000</jdbc-all-jar.maxsize> + <jdbc-all-jar.maxsize>52800000</jdbc-all-jar.maxsize> Review Comment: Can we exclude some unnecessary dependencies from JDBC Driver to avoid its inflation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org