vvysotskyi commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r933069130
########## exec/jdbc-all/pom.xml: ########## @@ -206,6 +231,38 @@ <groupId>io.swagger.core.v3</groupId> <artifactId>swagger-jaxrs2-servlet-initializer-v2</artifactId> </exclusion> + <exclusion> + <groupId>com.squareup.okhttp3</groupId> + <artifactId>okhttp</artifactId> + </exclusion> + <exclusion> + <groupId>com.tdunning</groupId> + <artifactId>t-digest</artifactId> + </exclusion> + <exclusion> + <groupId>com.bettercloud</groupId> + <artifactId>vault-java-driver</artifactId> + </exclusion> + <exclusion> + <groupId>com.esri.geometry</groupId> + <artifactId>esri-geometry-api</artifactId> + </exclusion> + <exclusion> + <groupId>com.yahoo.datasketches</groupId> + <artifactId>sketches-core</artifactId> + </exclusion> + <exclusion> + <groupId>org.apache.htrace</groupId> + <artifactId>htrace-core4</artifactId> + </exclusion> + <exclusion> + <groupId>${calcite.groupId}</groupId> + <artifactId>calcite-core</artifactId> + </exclusion> + <exclusion> + <groupId>${calcite.groupId}</groupId> + <artifactId>calcite-linq4j</artifactId> Review Comment: No need to exclude Calcite, and perhaps some other dependencies here, since they are already excluded from the target JAR in the configuration for `maven-shade-plugin`. ########## exec/jdbc-all/pom.xml: ########## @@ -329,8 +386,6 @@ </includes> <excludes> <exclude>io.protostuff:*</exclude> - <exclude>${calcite.groupId}:calcite-core</exclude> Review Comment: It is better to have exclusions here since they are applied to all dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org