LYCJeff commented on PR #2747: URL: https://github.com/apache/drill/pull/2747#issuecomment-1471106650
> @LYCJeff Thanks for making these changes. I have a few questions: > > 1. Are you certain that these filters are in fact being pushed down as intended? > 2. I'm really concerned about what would happen if a user aliased a data source as `header` or `tail`. > > IE: > > ```sql > SELECT ... > FROM api.foo > INNER JOIN dfs.`tail.csv` AS tail > ON tail.id = foo.id > WHERE tail.name = 'something' > ``` > > Do we know how this would be interpreted? Well, we actually need to recognize `header.xxx` as a whole parameter name, so we need to use back quotes. Only then can it be pushed normally, so these prefixes are not confused with data source aliases. If the `name` in your example above is an argument to the `foo` api, it should be written as follows. ```sql SELECT ... FROM api.foo INNER JOIN dfs.`tail.csv` AS tail ON tail.id=foo.id WHERE `tail.name` = 'something' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
