cgivre commented on code in PR #2747:
URL: https://github.com/apache/drill/pull/2747#discussion_r1169428023
##########
contrib/storage-http/README.md:
##########
@@ -138,11 +140,26 @@ key2=value2"
```
`postBodyLocation`: If the API uses the `POST` method, you can send
parameters in several different ways:
-* `query_string`: Parameters from the query are pushed down to the query
string. Static parameters are pushed to the post body.
Review Comment:
If the user enables this feature, are they required to specify the
destination of the supplied parameters? What happens if they don't?
##########
contrib/storage-http/README.md:
##########
@@ -15,6 +15,7 @@ To configure the plugin, create a new storage plugin, and add
the following conf
{
"type": "http",
"cacheResults": true,
+ "useLegacyRequestParamSyntax": false,
Review Comment:
See comment. I'd like to make the default behavior what Drill currently
does and have the user explicitly enable this functionality. Could we rename
this param `advanced` or `enhanced` and thus change the boolean to
`enableEnhancedParamSyntax`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
