pjfanning commented on code in PR #2800:
URL: https://github.com/apache/drill/pull/2800#discussion_r1189058399


##########
common/src/test/java/org/apache/drill/test/DrillTest.java:
##########
@@ -37,11 +38,10 @@
 
 public class DrillTest extends BaseTest {
 
-  protected static final ObjectMapper objectMapper;
+  private static final ObjectMapper objectMapper = 
JacksonUtils.createObjectMapper();

Review Comment:
   Some tests were using this mapper and modifying it - which seems like a 
dangerous thing to do because other tests will be affected by the modified 
mapper. I've changed the tests that used this mapper to create their own 
separate mappers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to