jnturton commented on code in PR #2800:
URL: https://github.com/apache/drill/pull/2800#discussion_r1189578197
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/http/oauth/OAuthUtils.java:
##########
@@ -36,6 +37,7 @@
public class OAuthUtils {
private static final Logger logger =
LoggerFactory.getLogger(OAuthUtils.class);
+ private static final ObjectMapper MAPPER = JacksonUtils.createObjectMapper();
Review Comment:
Hmm, reading [on little](https://stackoverflow.com/a/36162525/1153953)
reveals that lock contention in a shared ObjectMapper degrades performance for
multithreaded applications . Now I'm in two minds.
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/http/oauth/OAuthUtils.java:
##########
@@ -36,6 +37,7 @@
public class OAuthUtils {
private static final Logger logger =
LoggerFactory.getLogger(OAuthUtils.class);
+ private static final ObjectMapper MAPPER = JacksonUtils.createObjectMapper();
Review Comment:
Hmm, reading [on a little](https://stackoverflow.com/a/36162525/1153953)
reveals that lock contention in a shared ObjectMapper degrades performance for
multithreaded applications . Now I'm in two minds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
