handmadecode commented on PR #2907:
URL: https://github.com/apache/drill/pull/2907#issuecomment-2106221734

   > Awesome work. I can backport this too because you've left default 
behaviour unchanged (and it's self contained). My only question is about 
ParquetReaderConfig -- you've added switches to the global config system so I 
don't think we also need them to appear in the storage plugin config?
   
   Thanks.
   
   The reason I added the configuration properties to `ParquetReaderConfig` is 
that they are needed in 
`org.apache.drill.exec.store.parquet.metadata.FileMetadataCollector::addColumnMetadata`
 (to decide whether the metadata will be compared to timestamps with 
millisecond precision or to raw microsecond values). I couldn't find an easy 
way to access the global configuration values from there, but the 
`ParquetReaderConfig` instance was already available.
   
   However, I could very well have overlooked some way to access the global 
configuration, and I'd be grateful for any pointers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to