handmadecode commented on PR #2907: URL: https://github.com/apache/drill/pull/2907#issuecomment-2108103905
> Follow up: I see use of the FragmentContext class for accessing config options in the old Parquet reader, perhaps it's a good a vehicle... `FragmentContext` is used to access the new config options where an instance already was available, i.e. in `ColumnReaderFactory`, `ParquetToDrillTypeConverter`, and `DrillParquetGroupConverter`. `FileMetadataCollector` doesn't have access to a `FragmentContext`, only to a `ParquetReaderConfig`. I can only find a FragmentContext in one of the two call paths to `FileMetadataCollector::addColumnMetadata`, so trying to inject a `FragmentContext` into `FileMetadataCollector` will probably have an impact on quite a few other classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
