Hi James, OK... It built successfully on my laptop, so I'm going with a +1. Best, -- C
> On Jun 11, 2024, at 11:12 AM, Rumar, Maksym <maksym.ru...@hpe.com> wrote: > > Oh, yea... Then probably there is a need for another approach. > But as far as I remember there is no way to hide this warning > programmatically. > So, the only thing we can do is to hide the warning in the bundled sqlline, > or try to get rid of the libraries that attempt to access private API. > > Regards, > Maksym > ________________________________ > Від: James Turton <dz...@apache.org> > Надіслано: 11 червня 2024 р. 2:53 > Кому: Rumar, Maksym <maksym.ru...@hpe.com>; dev@drill.apache.org > <dev@drill.apache.org> > Тема: Re: [VOTE] Release Apache Drill 1.21.2 - RC1 > > Oh that's a great start that will take care of Drill's bundled sqlline. > I guess that other Java programs that load the JDBC driver could still > see warnings emitted? E.g. to reproduce the issue when you first > reported it, I used a standalone installation of sqlline... > > On 2024/06/10 13:28, Rumar, Maksym wrote: >> Hi James! >> >> How about the following solution: >> https://github.com/apache/drill/pull/2915 >> <https://github.com/apache/drill/pull/2915> >> We control shell options SQlline will use to start, so we can freely add >> the necessary ones. >> >> Regards, >> Maksym >> >> ------------------------------------------------------------------------ >> *Від:* James Turton <dz...@apache.org> >> *Надіслано:* 9 червня 2024 р. 11:54 >> *Кому:* dev@drill.apache.org <dev@drill.apache.org>; Rumar, Maksym >> <maksym.ru...@hpe.com> >> *Тема:* Re: [VOTE] Release Apache Drill 1.21.2 - RC1 >> Thanks Maksym. >> >> I checked and these reflective access warnings were already emitted by >> Drill's 1.20.3 JDBC driver (when I run sqlline in Java 17). I suppose >> we'll need to programmatically apply the rules below in the JDBC driver >> code since we can't control command line options used by external >> programs (which is how the Embedded Drill startup script avoids this log >> noise). My opinion is that we should fix it in master but not let it >> block the release of 1.21.2... >> >> --add-opens java.base/java.lang=ALL-UNNAMED ^ >> --add-opens java.base/java.util=ALL-UNNAMED ^ >> --add-opens java.base/sun.nio.ch=ALL-UNNAMED ^ >> --add-opens java.base/java.net=ALL-UNNAMED ^ >> --add-opens java.base/java.nio=ALL-UNNAMED ^ >> --add-opens java.security.jgss/sun.security.krb5=ALL-UNNAMED >> >> >> James >> >> On 2024/06/07 22:19, Rumar, Maksym wrote: >>> Hi all! >>> >>> I tested: >>> >>> * >>> a local building on maven 3.6.3 and 3.9.7, >>> * >>> web UI >>> * >>> parquet query >>> * >>> checked dependencies versions to match the release notes >>> * >>> sqlline >>> >>> Everything looks good except for the following warning message on >>> connection through sqlline. Was it there before? It's not critical, but >>> may be annoying. >>> >>> My vote: +1 >>> >>> apache drill> !connect jdbc:drill:drillbit=localhost; >>> WARNING: An illegal reflective access operation has occurred >>> WARNING: Illegal reflective access by >>> javassist.util.proxy.SecurityActions >>> (file:/home/rymarm/sandbox/test-drill-rc/apache-drill-1.21.2/jars/3rdparty/javassist-3.28.0-GA.jar >>> >>> <file:/home/rymarm/sandbox/test-drill-rc/apache-drill-1.21.2/jars/3rdparty/javassist-3.28.0-GA.jar>) >>> to method >>> java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) >>> WARNING: Please consider reporting this to the maintainers of >>> javassist.util.proxy.SecurityActions >>> WARNING: Use --illegal-access=warn to enable warnings of further illegal >>> reflective access operations >>> WARNING: All illegal access operations will be denied in a future release >>> apache drill> >>> >>> Regards, >>> Maksym Rymar >>
